Skip to content

refactor: logging using string interpolation - WPB-14876 #2480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 558 commits into
base: feat/create-new-logger-WPB-14297
Choose a base branch
from
Open

refactor: logging using string interpolation - WPB-14876 #2480

wants to merge 558 commits into from

Conversation

@caldrian
Copy link
Contributor

@caldrian caldrian commented Feb 5, 2025 •
edited by github-actions bot
Loading

StoryWPB-14876 [iOS] Create a new WireLogger interface

Issue

Please describe the issue.

Optional: add details about technical approach, solutions etc.

Optional: reference dependencies to other pull requests etc.

Testing

Describe how to test.

Optional: attachments like images, videos, etc.

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

caldrian and others added 30 commits November 22, 2024 15:32
@caldrian
Merge branch 'fix/sourcery-stencils-WPB-11881' into chore/move-WireLo…
9b41d8e 
…gger-into-WireFoundation-WPB-10941
@caldrian
fix imports
77a18eb
@caldrian
link WireFoundation into WireTransport
f9d8195
@caldrian
fix: allow for public imports in sourcery generated code - WPB-11881 (#…
72a5625 
…2176)
@caldrian
fix: showing/hiding empty conversation list placeholder - WPB-14386 (#…
fe83965 
…2179)
@caldrian
fix: network status view background color - WPB-14466 (#2189)
234e41d
@samwyndham
fix: Image selector anchor - WPB-11605 (#2100)
1611386
@caldrian
fix: status bar appearance on iPad - WPB-14474 (#2191)
47d5011
@caldrian
Merge branch 'release/cycle-3.114' of github.com:wireapp/wire-ios int…
86f9ba2 
…o chore/move-WireLogger-into-WireFoundation-WPB-10941

# Conflicts:
#	wire-ios-system/Source/ZMSLog.swift
#	wire-ios-system/WireSystem.xcodeproj/project.pbxproj
@samwyndham
fix: Applied filter view height - WPB-14421 (#2188)
af3ecdc
@samwyndham
fix: Move to folder picker tappable area - WPB-14469 (#2197)
166d69e
@caldrian
add existential any
641f1a6
@samwyndham
fix: Nav bar covers content in Guest & Services views - WPB-14452 (#2202
bd8e650 
)
@caldrian
fix warnings, remove unused global variable
bec1b44
@caldrian
minor preparations
9f6ce2b
@caldrian
Merge branch 'release/cycle-3.114' of github.com:wireapp/wire-ios int…
12a4c89 
…o chore/move-WireLogger-into-WireFoundation-WPB-10941
@caldrian
brainstorming
bbbf99f
@caldrian
WireAnalytics.setup()
1ad532d
@caldrian
add Sendable conformance
95a3ff9
@caldrian
Merge branch 'fix/make-WireLogger-Swift6-ready-WPB-11890' into chore/…
0b6fa8b 
…abstract-logging
@caldrian
create targets WireLogging etc.
069d93b
@caldrian
move file
6324a5d
@caldrian
Merge branch 'release/cycle-3.114' of github.com:wireapp/wire-ios int…
674d335 
…o chore/abstract-logging
@caldrian
attempt to extend WireLogInterpolation from outside
488c20b
@samwyndham
fix: Crash unwrapping MainCoordinator.splitViewController - WPB-145…
30efda2 
…10 (#2207)
@samwyndham
fix: Profile color tappable area - WPB-14525 (#2208)
c365522
@caldrian
chore: delete redundant LICENSE and README files - WPB-14567 (#2214)
272750f
@netbe
fix: back button style - WPB-14478 (#2213)
c58319e
@netbe
chore: bump avs to 9.10.16 - WPB-11904 (#2118)
805268b
@KaterinaWire
feat: Add scroll view to the passcode setup view - WPB-11836 (#2211)
fd6d0d3
Base automatically changed from feat/create-new-logger-WPB-14297 to chore/rename-wirelogging-to-wirelegacylogging-WPB-14876 November 5, 2025 15:05
@caldrian caldrian force-pushed the chore/rename-wirelogging-to-wirelegacylogging-WPB-14876 branch from e0dcbea to 076a3fc Compare November 5, 2025 15:08
caldrian added 14 commits November 5, 2025 16:08
@caldrian
Merge branch 'feat/create-new-logger-WPB-14297' into refactor/WireLog…
37e5ac8 
…ging-using-string-interpolation-WPB-14297
@caldrian
fix merge conflict
fa8effa
@caldrian
fix more build errors
d5c63d9
@caldrian
move wire logger instance to extension
43d9696
@caldrian
renaming
c6c1234
@caldrian
delete unused code
52b5655
@caldrian
fix build errors
1e96ac4
@caldrian
attempt to integrate sourcery as package
8904d79
@caldrian
Revert "attempt to integrate sourcery as package"
d5e984d 
This reverts commit 8904d79.
@caldrian
update packages
19bf284
@caldrian
Revert "update packages"
6a575ee 
This reverts commit 19bf284.
@caldrian
fix build error
933d6c8
@caldrian
Merge branch 'chore/rename-wirelogging-to-wirelegacylogging-WPB-14876…
e3b558b 
…' into refactor/WireLogging-using-string-interpolation-WPB-14297
@caldrian
Merge branch 'feat/create-new-logger-WPB-14297' into refactor/WireLog…
528bad5 
…ging-using-string-interpolation-WPB-14297
@caldrian caldrian changed the base branch from chore/rename-wirelogging-to-wirelegacylogging-WPB-14876 to feat/create-new-logger-WPB-14297 November 6, 2025 14:52
@caldrian
Merge branch 'feat/create-new-logger-WPB-14297' into refactor/WireLog…
d6486db 
…ging-using-string-interpolation-WPB-14297
@caldrian
Merge commit '91d5c8a4e42645ff6835860c046eca5068868d55' into refactor…
6685e7f 
…/WireLogging-using-string-interpolation-WPB-14297
@caldrian
Merge branch 'feat/create-new-logger-WPB-14297' into refactor/WireLog…
fbdf4ab 
…ging-using-string-interpolation-WPB-14297
@caldrian
logger cache
c332379
@caldrian
don't use NSCache
2b6c440
@caldrian
refactoring
736c7c9
@caldrian
finished
cf6da56
@caldrian
Merge branch 'feat/create-new-logger-WPB-14297' into refactor/WireLog…
b36c8cc 
…ging-using-string-interpolation-WPB-14297

# Conflicts:
#	WireLogging/Sources/WireLogging/LogHandler/OSLogHandler/OSLogHandler.swift
@caldrian caldrian marked this pull request as ready for review November 7, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@caldrian caldrian

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@caldrian @samwyndham @netbe @KaterinaWire @typfel